Skip to content

gh-96678: Fix UB of null pointer arithmetic #96782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2022
Merged

gh-96678: Fix UB of null pointer arithmetic #96782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38f6e2c
Assert for avoidance of undefined behaviour
matthiasgoergens Sep 13, 2022
48f25b9
Fix null pointer arithmetic
matthiasgoergens Sep 13, 2022
a6f2373
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 13, 2022
c30f501
Merge branch 'main' into matthias/ub-in-tokenizer
matthiasgoergens Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-09-13-12-06-46.gh-issue-96678.NqGFyb.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix undefined behaviour in C code of null pointer arithmetic.
2 changes: 1 addition & 1 deletion Parser/tokenizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1533,7 +1533,7 @@ tok_get(struct tok_state *tok, const char **p_start, const char **p_end)
} while (c == ' ' || c == '\t' || c == '\014');

/* Set start of current token */
tok->start = tok->cur - 1;
tok->start = tok->cur == NULL ? NULL : tok->cur - 1;

/* Skip comment, unless it's a type comment */
if (c == '#') {
Expand Down