Skip to content

Conversation

@jkloth
Copy link
Contributor

@jkloth jkloth commented May 17, 2022

With source build virtual environments sorted out, this test also runs just fine on Windows. Requires #92897.

Adding @vstinner due to recent work on this test.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels May 17, 2022
@jkloth
Copy link
Contributor Author

jkloth commented May 17, 2022

The Windows test failures are to be expected until #92897 is resolved.

@serhiy-storchaka
Copy link
Member

There are merge conflicts now. It may be easier to recreate this change from scratch than try to resolve them.

@vstinner
Copy link
Member

I tried to add the following code to setup.py, but setup.py stil fails to find python313_d.lib, it looks for python313.lib :-(

    include_dirs = []
    library_dirs = []
    if support.MS_WINDOWS:
        # pyconfig.h is created in PCbuild\amd64\
        # python313.lib is created in  PCbuild\amd64\
        src_dir = dirname(dirname(dirname(os.getcwd())))
        build_dir = os.path.join(src_dir, 'PCbuild', 'amd64')
        include_dirs.append(build_dir)
        library_dirs.append(build_dir)

@vstinner
Copy link
Member

I wrote a new PR from scratch: #117000

PR are now run on Windows, but only on release build.

@vstinner vstinner closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants