Skip to content

gh-77630: Change Charset to charset #92439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2022
Merged

gh-77630: Change Charset to charset #92439

merged 3 commits into from
May 8, 2022

Conversation

@slateny
Copy link
Contributor

@slateny slateny commented May 8, 2022

@slateny slateny requested a review from a team as a code owner May 8, 2022 02:20
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 8, 2022
serhiy-storchaka
serhiy-storchaka requested changes May 8, 2022
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix also docstrings in the email.charset module.

@bedevere-bot
Copy link

bedevere-bot commented May 8, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

serhiy-storchaka
serhiy-storchaka approved these changes May 8, 2022
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@serhiy-storchaka serhiy-storchaka merged commit 8f29318 into python:main May 8, 2022
@miss-islington
Copy link
Contributor

miss-islington commented May 8, 2022

Thanks @slateny for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2022
@slateny @miss-islington
pythongh-77630: Change Charset to charset (pythonGH-92439)
b9adabb 
(cherry picked from commit 8f29318)

Co-authored-by: slateny <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 8, 2022
@bedevere-bot
Copy link

bedevere-bot commented May 8, 2022

GH-92476 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2022
@slateny @miss-islington
pythongh-77630: Change Charset to charset (pythonGH-92439)
1023ea4 
(cherry picked from commit 8f29318)

Co-authored-by: slateny <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented May 8, 2022

GH-92477 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request May 8, 2022
@miss-islington
[3.10] gh-77630: Change Charset to charset (GH-92439) (GH-92476)
a7d869a 
(cherry picked from commit 8f29318)


Co-authored-by: slateny <[email protected]>

Automerge-Triggered-By: GH:serhiy-storchaka
miss-islington added a commit that referenced this pull request May 8, 2022
@miss-islington
[3.9] gh-77630: Change Charset to charset (GH-92439) (GH-92477)
bab6954 
(cherry picked from commit 8f29318)


Co-authored-by: slateny <[email protected]>

Automerge-Triggered-By: GH:serhiy-storchaka
@slateny slateny deleted the s/charset branch May 9, 2022 10:09
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @hello-adam
[3.9] pythongh-77630: Change Charset to charset (pythonGH-92439) (pyt…
caf209c 
…honGH-92477)

(cherry picked from commit 8f29318)


Co-authored-by: slateny <[email protected]>

Automerge-Triggered-By: GH:serhiy-storchaka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-email

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slateny @bedevere-bot @miss-islington @serhiy-storchaka