bpo-34068: _io__IOBase_close_impl could call _PyObject_SetAttrId with an exception set

[ZackerySpytz]

https://bugs.python.org/issue34068

[serhiy-storchaka]

The code could be simpler:

    PyErr_Fetch(&exc, &val, &tb);
    rc = _PyObject_SetAttrId(self, &PyId___IOBase_closed, Py_True);
    _PyErr_ChainExceptions(exc, val, tb);
    if (rc < 0) {
        Py_CLEAR(res);
    }

[vstinner]

LGTM, but I have a minor request on the NEWS entry.

[vstinner]

In the changelog, you should try to avoid to mention low-level C internals. You can say something like: "In io.IOBase.close, ensure that the closed attribute is not set to True with a live exception. (...)".

[miss-islington]

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

[miss-islington]

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

[miss-islington]

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

[bedevere-bot]

GH-8310 is a backport of this pull request to the 3.7 branch.

[miss-islington]

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 28f07364f066792ceee93231dbb80ae8ad98b2bb 3.6

[miss-islington]

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 28f07364f066792ceee93231dbb80ae8ad98b2bb 2.7

[bedevere-bot]

GH-8312 is a backport of this pull request to the 3.6 branch.

[vstinner]

Tweak the news entry.

Thanks. It now LGTM ;-) Thanks for the fix @ZackerySpytz!