bpo-29910: IDLE no longer delete character after commenting out a region #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by key shortcut. Fixed also other potential conflicts between IDLE's and default key bindings.
serhiy-storchaka
added
type-bug
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @tiran and @terryjreedy to be potential reviewers. |
terryjreedy
requested changes
Mar 26, 2017
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
Review on b.p.o, tests needed
terryjreedy
reviewed
Jun 27, 2017
Misc/NEWS
Outdated
| - Issue #29910: IDLE no longer delete character after commenting out a region | ||
| by key shortcut. Fixed also other potential conflicts between IDLE's and | ||
| default key bindings. | ||
|
|
Member
There was a problem hiding this comment.
I will move this to separate file, as now required.
terryjreedy
reviewed
Jun 27, 2017
Misc/NEWS
Outdated
| - Issue #29910: IDLE no longer delete character after commenting out a region | ||
| by key shortcut. Fixed also other potential conflicts between IDLE's and | ||
| default key bindings. | ||
|
|
Member
There was a problem hiding this comment.
This news item was misplaced anyway, under the 3.6b1 section.
terryjreedy
force-pushed
the
idle-break-event-handlers
branch
from
407c966 to
ee8d769
Compare
Member
Author
|
Thanks for merging this Terry. |
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jun 27, 2017
…out a region (pythonGH-825) This happened because shortcut has a class binding and 'break' was not returned. Fix other potential conflicts between IDLE and default key bindings. * Add news item * Update NEWS (cherry picked from commit 213ce12)
|
GH-2429 is a backport of this pull request to the 3.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by key shortcut. Fixed also other potential conflicts between IDLE's and
default key bindings.