bpo-33924: original missed mac-specific menudef 'windows' to 'window'… #7920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @roseman for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-7922 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2018
…honGH-7920) These should have been included in PR 7836. (cherry picked from commit 4239773) Co-authored-by: Mark Roseman <[email protected]>
|
GH-7923 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 26, 2018
…honGH-7920) These should have been included in PR 7836. (cherry picked from commit 4239773) Co-authored-by: Mark Roseman <[email protected]>
Member
|
Whoops. I will re-check 'windows' grep output for anything else. The test_macosx coverage, now 45%, needs to be increased. The nested functions would be easy to test if pulled out to module scope. Is there any problem with circular imports failing if the 3 imports within overrideRootMenu are also moved to module scope, at the top? That would allow No news needed because this is a continuation of PR #7836. |
miss-islington
added a commit
that referenced
this pull request
Jun 26, 2018
…7920) These should have been included in PR 7836. (cherry picked from commit 4239773) Co-authored-by: Mark Roseman <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 26, 2018
…7920) These should have been included in PR 7836. (cherry picked from commit 4239773) Co-authored-by: Mark Roseman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two missed instances of 'windows' to 'window' conversion in the recent commit, specific to macOS. Prevents IDLE from starting.
https://bugs.python.org/issue33924