bpo-33716: test_concurrent_futures: increase timeout #7828
Conversation
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
The commit message can be enhanced:
- Try to write a shorter title (first line)
- I'm not sure that 5' unit is commonly known, I suggest to use the more common "5 min".
Example of commit message:
bpo-33716, test_concurrent_futures: increase timeout
Increase the timeout from 1 min to 5 min.
Replace also time.time() with time.monotonic() for timeouts.
You can use git push --force here to rewrite the commit message.
|
When you're done making the requested changes, leave the comment: |
pablogsal
changed the title
test_concurrent_futures
Increase the timeout from 1 min to 5 min. Replace also time.time() with time.monotonic() for timeouts.
|
@vstinner Thanks! I was under the assumption that all the commits will be squashed when the PR is merged and the final merged commit message will be rewritten there. ✏️ I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
vstinner
dismissed
their stale review
Hum, I asked a question on https://bugs.python.org/issue33716
|
@pitrou: I proposed to increase the timeout from 1 min to 5 min to repair buildbots, but does the check still make sense with a maximum duration of 5 minutes? https://bugs.python.org/issue33716#msg320126 |
|
@pablogsal: I added the "skip news" label. I don't think that a NEWS entry is needed for such simple test change. I only add a NEWS entry for major changes in tests. |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-8263 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @pablogsal, I could not cleanly backport this to |
Increase the timeout from 1 min to 5 min. Replace also time.time() with time.monotonic() for timeouts. (cherry picked from commit 3ad8dec) Co-authored-by: Pablo Galindo <[email protected]>
|
GH-8264 is a backport of this pull request to the 3.6 branch. |
Increase the timeout from 1 min to 5 min. Replace also time.time() with time.monotonic() for timeouts. (cherry picked from commit 3ad8dec) Co-authored-by: Pablo Galindo <[email protected]>
5 participants
https://bugs.python.org/issue33716