Skip to content

bpo-33772: Fix couple of dead code paths #7418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from May 17, 2019
Merged

bpo-33772: Fix couple of dead code paths #7418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Objects/bytesobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,12 +1607,10 @@ bytes_richcompare(PyBytesObject *a, PyBytesObject *b, int op)
case Py_GE:
/* a string is equal to itself */
Py_RETURN_TRUE;
break;
case Py_NE:
case Py_LT:
case Py_GT:
Py_RETURN_FALSE;
break;
default:
PyErr_BadArgument();
return NULL;
Expand Down
1 change: 0 additions & 1 deletion Objects/stringlib/fastsearch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ FASTSEARCH(const STRINGLIB_CHAR* s, Py_ssize_t n,
}
return count;
}
return -1;
}

mlast = m - 1;
Expand Down
3 changes: 0 additions & 3 deletions Python/ast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2637,7 +2637,6 @@ ast_for_expr(struct compiling *c, const node *n)
return Compare(expression, ops, cmps, LINENO(n),
n->n_col_offset, c->c_arena);
}
break;

case star_expr:
return ast_for_starred(c, n);
Expand Down Expand Up @@ -3198,7 +3197,6 @@ alias_for_import_name(struct compiling *c, const node *n, int store)
return NULL;
return a;
}
break;
case dotted_name:
if (NCH(n) == 1) {
node *name_node = CHILD(n, 0);
Expand Down Expand Up @@ -3249,7 +3247,6 @@ alias_for_import_name(struct compiling *c, const node *n, int store)
}
return alias(str, NULL, c->c_arena);
}
break;
case STAR:
str = PyUnicode_InternFromString("*");
if (PyArena_AddPyObject(c->c_arena, str) < 0) {
Expand Down
1 change: 0 additions & 1 deletion Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4597,7 +4597,6 @@ compiler_visit_expr(struct compiler *c, expr_ty e)
return compiler_error(c,
"can't use starred expression here");
}
break;
case Name_kind:
return compiler_nameop(c, e->v.Name.id, e->v.Name.ctx);
/* child nodes of List and Tuple will have expr_context set */
Expand Down