Reverse the meaning of is_argument when used for type check #7039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
May 22, 2018
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks!
It looks like Travis failure is unrelated. I will try restarting the tests.
Contributor
|
Sorry, looks like we still have flaky asyncio tests. |
Contributor
Author
|
Thanks @asvetlov. @ilevkivskyi -- looks like the tests are all green ✅now. |
Contributor
|
Thanks @nnja for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-7066 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 23, 2018
…-7039) (cherry picked from commit 0e61dff) Co-authored-by: Nina Zakharenko <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 23, 2018
(cherry picked from commit 0e61dff) Co-authored-by: Nina Zakharenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse the meaning of
is_argumentadded in #6824, per this review: #6824 (review)