Skip to content

[3.7] Fix ClassVar as string fails when getting type hints (GH-6824) #6912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2018
Merged

[3.7] Fix ClassVar as string fails when getting type hints (GH-6824) #6912

merged 1 commit into from
May 16, 2018

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 16, 2018

(cherry picked from commit 2d2d3b1)

Co-authored-by: Nina Zakharenko [email protected]

@nnja @miss-islington
Fix ClassVar as string fails when getting type hints (pythonGH-6824)
9384427 
(cherry picked from commit 2d2d3b1)

Co-authored-by: Nina Zakharenko <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request May 16, 2018
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented May 16, 2018

@nnja and @ambv: Backport status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

miss-islington commented May 16, 2018

@nnja and @ambv: Backport status check is done, and it's a success ✅ .

@ambv ambv merged commit 9c17cd3 into python:3.7 May 16, 2018
@bedevere-bot
Copy link

bedevere-bot commented May 16, 2018

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor Author

miss-islington commented May 16, 2018

Thanks, @ambv!

@miss-islington miss-islington deleted the backport-2d2d3b1-3.7 branch May 16, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi ilevkivskyi is a code owner

Assignees

No one assigned

Labels

skip issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @bedevere-bot @ambv @the-knights-who-say-ni @nnja