bpo-33473: Be slightly better about CFLAGS, LDFLAGS, and related #6771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimreaper
changed the title
grimreaper
force-pushed
the
eax/pthread/pthread_pass_correct
branch
from
d97b5e6 to
2465e3c
Compare
grimreaper
changed the title
grimreaper
force-pushed
the
eax/pthread/pthread_pass_correct
branch
from
2465e3c to
3162aed
Compare
grimreaper
changed the title
benjaminp
reviewed
May 13, 2018
configure.ac
Outdated
Contributor
There was a problem hiding this comment.
Won't this now stomp over whatever BASECFLAGS was before?
Contributor
Author
There was a problem hiding this comment.
good call; I believe this has been fixed.
grimreaper
force-pushed
the
eax/pthread/pthread_pass_correct
branch
2 times, most recently
from
be7840e to
e975ab2
Compare
benjaminp
reviewed
May 13, 2018
configure.ac
Outdated
Contributor
There was a problem hiding this comment.
this line seems rather otiose now
configure.ac
Outdated
configure.ac
Outdated
Contributor
There was a problem hiding this comment.
this also stamps over whatever CXXFLAGS was before
Also, it seems the cases above need this treatment?
configure.ac
Outdated
Contributor
There was a problem hiding this comment.
if you're going to change it, you need to save and restore CFLAGS as is done for CC
Contributor
Author
|
I think I have a much better way of handling this. Let me try; if it works, I'll close this. |
Contributor
Author
|
#6788 will drastically change how this is implemented, if accepted. It still requires work, but I'd rather see that PR committed first so we can work from a non-conflicting base. |
grimreaper
force-pushed
the
eax/pthread/pthread_pass_correct
branch
5 times, most recently
from
4d052ae to
692fb84
Compare
grimreaper
force-pushed
the
eax/pthread/pthread_pass_correct
branch
2 times, most recently
from
bf5317d to
c3e6cc6
Compare
grimreaper
force-pushed
the
eax/pthread/pthread_pass_correct
branch
from
c3e6cc6 to
079c775
Compare
grimreaper
force-pushed
the
eax/pthread/pthread_pass_correct
branch
2 times, most recently
from
2b2b23c to
66b076d
Compare
- "-pthread" is a part of the C compiler and linker flags. It is not part of the compiler. In particular 'make CC=clang' ought to work - checking for pthreads support is a link time issue, not run time Not done in this patch: - convert from "gcc" to "cc" to more correctly infer the current compiler - regenerate generated code such as "configure" or "aclocal.m4"
grimreaper
force-pushed
the
eax/pthread/pthread_pass_correct
branch
from
66b076d to
d6ae20c
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of the compiler. In particular 'make CC=clang' ought to work
Not done in this patch:
compiler
https://bugs.python.org/issue33473