bpo-29209: Remove old-deprecated features in ElementTree. #6769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make getchildren() and getiterator() emitting a DeprecationWarning instead of PendingDeprecationWarning.
serhiy-storchaka
force-pushed
the
etree-remove-deprecated
branch
from
37b9b3b to
3207edc
Compare
Carreau
reviewed
May 16, 2018
| "This method will be removed in future versions. " | ||
| "Use 'tree.iter()' or 'list(tree.iter())' instead.", | ||
| PendingDeprecationWarning, stacklevel=2 | ||
| DeprecationWarning, stacklevel=2 |
Contributor
There was a problem hiding this comment.
Do you want to update the messages to have the version since the deprecation and the planned removal version here (and on line 418) ?
Member
Author
There was a problem hiding this comment.
It is in the documentation.
Carreau
reviewed
May 16, 2018
| warnings.warn( | ||
| "The doctype() method of XMLParser is ignored. " | ||
| "Define doctype() method on the TreeBuilder target.", | ||
| RuntimeWarning) |
Carreau
approved these changes
May 16, 2018
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jul 25, 2018
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make getchildren() and getiterator() emitting a DeprecationWarning instead of PendingDeprecationWarning.
https://bugs.python.org/issue29209