bpo-33295: Skip test using missing external site #6504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test_urllib2net.OtherNetworkTests.test_sites_no_connection_close` used `http://www.imdb.com/` but it is moved to https so the test is not valid anymore.
Contributor
|
Thanks @methane for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 17, 2018
`test_urllib2net.OtherNetworkTests.test_sites_no_connection_close` used `http://www.imdb.com/` but it is moved to https so the test is not valid anymore. Skip test for the moment to allow CI to proceed. (cherry picked from commit 36d56ea) Co-authored-by: INADA Naoki <[email protected]>
|
GH-6509 is a backport of this pull request to the 3.7 branch. |
|
GH-6510 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 17, 2018
`test_urllib2net.OtherNetworkTests.test_sites_no_connection_close` used `http://www.imdb.com/` but it is moved to https so the test is not valid anymore. Skip test for the moment to allow CI to proceed. (cherry picked from commit 36d56ea) Co-authored-by: INADA Naoki <[email protected]>
ned-deily
pushed a commit
that referenced
this pull request
Apr 17, 2018
`test_urllib2net.OtherNetworkTests.test_sites_no_connection_close` used `http://www.imdb.com/` but it is moved to https so the test is not valid anymore. Skip test for the moment to allow CI to proceed. (cherry picked from commit 36d56ea) Co-authored-by: INADA Naoki <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 17, 2018
`test_urllib2net.OtherNetworkTests.test_sites_no_connection_close` used `http://www.imdb.com/` but it is moved to https so the test is not valid anymore. Skip test for the moment to allow CI to proceed. (cherry picked from commit 36d56ea) Co-authored-by: INADA Naoki <[email protected]>
|
GH-6511 is a backport of this pull request to the 3.6 branch. |
ned-deily
pushed a commit
that referenced
this pull request
Apr 17, 2018
`test_urllib2net.OtherNetworkTests.test_sites_no_connection_close` used `http://www.imdb.com/` but it is moved to https so the test is not valid anymore. Skip test for the moment to allow CI to proceed. (cherry picked from commit 36d56ea) Co-authored-by: INADA Naoki <[email protected]>
ned-deily
pushed a commit
that referenced
this pull request
Apr 17, 2018
`test_urllib2net.OtherNetworkTests.test_sites_no_connection_close` used `http://www.imdb.com/` but it is moved to https so the test is not valid anymore. Skip test for the moment to allow CI to proceed. (cherry picked from commit 36d56ea) Co-authored-by: INADA Naoki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_urllib2net.OtherNetworkTests.test_sites_no_connection_closeused
http://www.imdb.com/but it is moved to https so the test isnot valid anymore.
https://bugs.python.org/issue33295