-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
Fix typo in comment at the end of conditional block #5681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ngie Cooper <[email protected]>
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
Thanks @ngie-eign and congrats on your first contribution to CPython 🌮 |
|
Thanks @ngie-eign for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
Thanks @ngie-eign for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7. |
|
Thanks @ngie-eign for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-5686 is a backport of this pull request to the 3.6 branch. |
A closing parentheses was missing. Signed-off-by: Ngie Cooper <[email protected]> (cherry picked from commit 7745ec4) Co-authored-by: ngie-eign <[email protected]>
|
GH-5687 is a backport of this pull request to the 2.7 branch. |
A closing parentheses was missing. Signed-off-by: Ngie Cooper <[email protected]> (cherry picked from commit 7745ec4) Co-authored-by: ngie-eign <[email protected]>
|
GH-5688 is a backport of this pull request to the 3.7 branch. |
A closing parentheses was missing. Signed-off-by: Ngie Cooper <[email protected]> (cherry picked from commit 7745ec4) Co-authored-by: ngie-eign <[email protected]>
A closing parentheses was missing. Signed-off-by: Ngie Cooper <[email protected]> (cherry picked from commit 7745ec4) Co-authored-by: ngie-eign <[email protected]>
A closing parentheses was missing. Signed-off-by: Ngie Cooper <[email protected]> (cherry picked from commit 7745ec4) Co-authored-by: ngie-eign <[email protected]>
A closing parentheses was missing. Signed-off-by: Ngie Cooper <[email protected]> (cherry picked from commit 7745ec4) Co-authored-by: ngie-eign <[email protected]>
|
@Mariatta: thank you for the note -- I'll definitely sign the CLA, since I plan on contributing more changes in the future. |
Signed-off-by: Enji Cooper [email protected]