bpo-32841: Asyncio.Condition prevents cancellation #5665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
approved these changes
Feb 13, 2018
Member
|
@asvetlov Andrew please take a look. |
Contributor
Author
|
@1st1 Hey mate, seems like the build failed because of a whitespace issue in the tests file. I have a fully enabled linter which doesn't really know what whitespace issue is it talking about. |
Contributor
Author
|
Alright. Seems like whitespace issues were fixed even though they weren't on any part of my code >.< |
Contributor
|
@asvetlov: Please replace |
|
GH-5682 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 14, 2018
) (cherry picked from commit 5746510) Co-authored-by: Bar Harel <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 14, 2018
) (cherry picked from commit 5746510) Co-authored-by: Bar Harel <[email protected]>
|
GH-5683 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 14, 2018
(cherry picked from commit 5746510) Co-authored-by: Bar Harel <[email protected]>
asvetlov
pushed a commit
that referenced
this pull request
Feb 14, 2018
…H-5683) (cherry picked from commit 5746510) Co-authored-by: Bar Harel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright.
Fixed, added tests, and added news.
https://bugs.python.org/issue32841