Skip to content

Conversation

@ndparker
Copy link
Contributor

@ndparker ndparker commented Mar 8, 2017

Including pyport.h into a module compiled with a C89/90 compiler gives the error:

C++ style comments are not allowed in ISO C90.

It would be nice to be included into the next python 3.6 version as well.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement. The "bugs.python.org username " requested by the form is the "Login name" field under "Your Details".
  4. If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@mention-bot
Copy link

@ndparker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @tim-one, @Yhg1s, @mdickinson and @mhammond to be potential reviewers.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Mar 8, 2017
@serhiy-storchaka serhiy-storchaka merged commit f7eda38 into python:master Mar 8, 2017
@serhiy-storchaka
Copy link
Member

Could you please backport this change to 3.6 @ndparker?

@ndparker
Copy link
Contributor Author

ndparker commented Mar 8, 2017

FWIW, I've signed the CLA now :-)

@serhiy-storchaka Thanks for merging. Should I open another PR for python 3.6 or how is it supposed to be done?

@serhiy-storchaka
Copy link
Member

Thanks @ndparker. Signing the CLA for such trivial change is not needed, but i hope this is not your last contribution.

Just open another PR for Python 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants