Skip to content

bpo-27169: The __debug__ constant is now optimized out at compile time. #4880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2017
Merged

bpo-27169: The __debug__ constant is now optimized out at compile time. #4880

merged 1 commit into from
Dec 15, 2017

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 15, 2017 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Dec 15, 2017
methane
methane approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit 3325a67 into python:master Dec 15, 2017
@serhiy-storchaka serhiy-storchaka deleted the compile-__debug__ branch December 15, 2017 10:35
@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 and removed type-feature A feature request or enhancement labels Dec 15, 2017
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3325a6780c81f1ea51190370b5454879c4862a37 3.6

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 15, 2017
@serhiy-storchaka
[3.6] bpo-27169: The __debug__ constant is now optimized out at compi…
655e04a 
…le time. (pythonGH-4880)

This fixes also bpo-22091..
(cherry picked from commit 3325a67)
@bedevere-bot
Copy link

GH-4882 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit that referenced this pull request Dec 15, 2017
@serhiy-storchaka
[3.6] bpo-27169: The __debug__ constant is now optimized out at compi…
b82da9e 
…le time. (GH-4880) (#4882)

This fixes also bpo-22091..
(cherry picked from commit 3325a67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @methane @the-knights-who-say-ni