bpo-32197: Try to fix a compiler error on OS X introduced in bpo-32030. #4681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython#4673)" This reverts commit af5a895.
This reverts commit e23c06e.
This reverts commit 0ea395a.
…python#4667)" This reverts commit ebac19d.
This reverts commit 9ac3d88.
ned-deily
approved these changes
Dec 2, 2017
Member
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
Reverting for now LGTM. Thanks!
CuriousLearner
approved these changes
Dec 2, 2017
vstinner
added a commit
that referenced
this pull request
Dec 4, 2017
…po-32030. (#4681)" (#4694) * Revert "bpo-32197: Try to fix a compiler error on OS X introduced in bpo-32030. (#4681)" This reverts commit 13badcb. Re-apply commits: * "bpo-32030: _PyPathConfig_Init() sets home and program_name (#4673)" commit af5a895. * "bpo-32030: Fix config_get_program_name() on macOS (#4669)" commit e23c06e. * "bpo-32030: Add Python/pathconfig.c (#4668)" commit 0ea395a. * "bpo-32030: Don't call _PyPathConfig_Fini() in Py_FinalizeEx() (#4667)" commit ebac19d. * "bpo-32030: Fix Py_GetPath(): init program_name (#4665)" commit 9ac3d88. * Fix compilation error on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32197