bpo-46510: simplify exception handling code in xmlrpc #30878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
approved these changes
Jan 25, 2022
iritkatriel
changed the title
vstinner
approved these changes
Jan 25, 2022
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
I would be better to only catch Exception, rather than BaseException, but it should be addressed in a separated PR if anyone cares. This change is more a refactoring, it's better if it doesn't change the behavior ;-)
Member
Author
Exactly - I don't know the context enough to know whether just Exception is ok. Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these are covered by tests.
https://bugs.python.org/issue46510