bpo-46491: Allow Annotated on outside of Final/ClassVar #30864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order.
GBeauregard
requested review from
Fidget-Spinner and
gvanrossum
as code owners
JelleZijlstra
requested changes
Jan 25, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks for your contribution! A few comments.
Misc/NEWS.d/next/Library/2022-01-24-23-55-30.bpo-46491.jmIKHo.rst
Outdated
Show resolved
Hide resolved
Member
|
Please add me back once this is ready to merge. |
Misc/NEWS.d/next/Library/2022-01-24-23-55-30.bpo-46491.jmIKHo.rst
Outdated
Show resolved
Hide resolved
JelleZijlstra
approved these changes
Jan 25, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
@gvanrossum I think this is ready now.
gvanrossum
approved these changes
Jan 25, 2022
Member
|
Maybe this should be backported? |
JelleZijlstra
added
needs backport to 3.9
needs backport to 3.10
Member
|
Agree, I added the labels |
Contributor
|
@GBeauregard: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @GBeauregard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
GH-30873 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2022
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit e1abffc) Co-authored-by: Gregory Beauregard <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 25, 2022
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit e1abffc) Co-authored-by: Gregory Beauregard <[email protected]>
|
GH-30874 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Jan 25, 2022
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit e1abffc) Co-authored-by: Gregory Beauregard <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jan 25, 2022
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit e1abffc) Co-authored-by: Gregory Beauregard <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit e1abffc) Co-authored-by: Gregory Beauregard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We treat Annotated type arg as class-level annotation. This exempts it from checks against Final and ClassVar in order to allow using them in any nesting order.
https://bugs.python.org/issue46491
Automerge-Triggered-By: GH:gvanrossum