bpo-46442: improve testExceptionCleanupNames #30758
Conversation
ericvsmith
left a comment
ericvsmith
left a comment
There was a problem hiding this comment.
With the small noted changes, I think this is ready to commit.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
ericvsmith
added
needs backport to 3.9
needs backport to 3.10
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically.
|
|
|
Thanks for making the requested changes! @ericvsmith: please review the changes made to this pull request. |
|
Thanks @yellowdusk1590 for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <[email protected]>
|
GH-30778 is a backport of this pull request to the 3.10 branch. |
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <[email protected]>
|
GH-30779 is a backport of this pull request to the 3.9 branch. |
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <[email protected]>
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <[email protected]>
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <[email protected]>
8 participants
The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
https://bugs.python.org/issue46442