Skip to content

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 24, 2021

@markshannon
Copy link
Member

OOI, what is the reason for adding these to test_trace, instead of test.test_sys_settrace?
E.g. https://github.com/python/cpython/blob/main/Lib/test/test_sys_settrace.py#L638

The expected output in test.test_sys_settrace is stricter (as it is ordered) and a clearer, IMO.

@iritkatriel
Copy link
Member Author

I didn't notice test.test_sys_settrace, let me check.

@iritkatriel
Copy link
Member Author

test.test_sys_settrace. has some of these, maybe I can add a case or two.

Why are the tests there numbered? Can I change the numbers?

@markshannon
Copy link
Member

Thanks

@markshannon markshannon merged commit a310fd8 into python:main Dec 7, 2021
@iritkatriel iritkatriel deleted the bpo-45890 branch December 8, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants