Skip to content

bpo-31034: Reliable signal handler for test_asyncio #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2017
Merged

bpo-31034: Reliable signal handler for test_asyncio #2867

merged 2 commits into from
Jul 25, 2017

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jul 25, 2017 •
edited by bedevere-bot
Loading

Don't rely on the current SIGHUP signal handler, make sure that it's
set to the "default" signal handler: SIG_DFL.

https://bugs.python.org/issue31034

@vstinner
bpo-31034: Reliable signal handler for test_asyncio
817cbe9 
Don't rely on the current SIGHUP signal handler, make sure that it's
set to the "default" signal handler: SIG_DFL.
@brettcannon brettcannon changed the title bpo-31034: Reliable signal handler for test_asyncio Reliable signal handler for test_asyncio Jul 25, 2017
@brettcannon brettcannon changed the title Reliable signal handler for test_asyncio bpo-31034: Reliable signal handler for test_asyncio Jul 25, 2017
@brettcannon brettcannon changed the title bpo-31034: Reliable signal handler for test_asyncio Reliable signal handler for test_asyncio Jul 25, 2017
@brettcannon brettcannon changed the title Reliable signal handler for test_asyncio bpo-31034: Reliable signal handler for test_asyncio Jul 25, 2017
@brettcannon
Copy link
Member

brettcannon commented Jul 25, 2017

Sorry about the title change noise: trying to figure out why this PR wasn't editable.

@Mariatta
Copy link
Member

Mariatta commented Jul 25, 2017

It's editable now 👍

@vstinner
Copy link
Member Author

vstinner commented Jul 25, 2017

why this PR wasn't editable

Did it do something wrong?

@vstinner vstinner merged commit 8300809 into python:master Jul 25, 2017
@vstinner vstinner deleted the asyncio_sig_dfl branch July 25, 2017 17:19
@brettcannon
Copy link
Member

brettcannon commented Jul 25, 2017

@Haypo yep, we ran into a bug in GitHub's API that was automatically turning off the ability to edit PRs by project maintainers. New deployment of Bedevere works around the bug and I used this PR to test the fix. 😀

@vstinner
Copy link
Member Author

vstinner commented Jul 25, 2017

"New deployment of Bedevere works around the bug and I used this PR to test the fix. 😀"

Oh ok, no problem. It seems like at the end, it works, nice ;-)

@bedevere-bot
Copy link

bedevere-bot commented Jul 26, 2017

GH-2876 is a backport of this pull request to the 3.6 branch.

vstinner added a commit that referenced this pull request Jul 26, 2017
@vstinner
bpo-31034: Reliable signal handler for test_asyncio (#2867) (#2876)
efe9fcb 
* bpo-31034: Reliable signal handler for test_asyncio

Don't rely on the current SIGHUP signal handler, make sure that it's
set to the "default" signal handler: SIG_DFL.

* Add comments

(cherry picked from commit 8300809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @brettcannon @Mariatta @bedevere-bot @the-knights-who-say-ni