Skip to content

bpo-45128: fixes test_multiprocessing_fork mysterious crash #28387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 19, 2021
Merged

bpo-45128: fixes test_multiprocessing_fork mysterious crash #28387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1b1ae07
bpo-45128: fixes `test_multiprocessing_fork` mysterious crash
sobolevn Sep 16, 2021
c9028b2
Extra test
sobolevn Sep 16, 2021
a70dd41
Extra test
sobolevn Sep 16, 2021
4fd1381
Update Misc/NEWS.d/next/Tests/2021-09-16-17-22-35.bpo-45128.Jz6fl2.rst
sobolevn Sep 16, 2021
6caffde
Isolates test_multiprocessing
sobolevn Sep 16, 2021
a48afcb
Removes regression test
sobolevn Sep 16, 2021
f11bc50
Update 2021-09-16-17-22-35.bpo-45128.Jz6fl2.rst
sobolevn Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4437,8 +4437,10 @@ def _extract_logrecord_process_name(key, logMultiprocessing, conn=None):
name = mp.current_process().name

r1 = logging.makeLogRecord({'msg': f'msg1_{key}'})
del sys.modules['multiprocessing']
r2 = logging.makeLogRecord({'msg': f'msg2_{key}'})

# https://bugs.python.org/issue45128
with support.swap_item(sys.modules, 'multiprocessing', None):
r2 = logging.makeLogRecord({'msg': f'msg2_{key}'})

results = {'processName' : name,
'r1.processName': r1.processName,
Expand Down Expand Up @@ -4487,7 +4489,6 @@ def test_multiprocessing(self):
if multiprocessing_imported:
import multiprocessing


def test_optional(self):
r = logging.makeLogRecord({})
NOT_NONE = self.assertIsNotNone
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2021-09-16-17-22-35.bpo-45128.Jz6fl2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix ``test_multiprocessing_fork`` failure due to ``test_logging`` and
``sys.modules`` manipulation.