bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. #28194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PyAiter_Check to only check for the `__anext__` presense (not for `__aiter__`). Rename `PyAiter_Check()` to `PyAIter_Check()`, `PyObject_GetAiter()` -> `PyObject_GetAIter()`.
sweeneyde
reviewed
Sep 7, 2021
Misc/NEWS.d/next/Core and Builtins/2021-09-06-21-52-45.bpo-45123.8Eh9iI.rst
Outdated
Show resolved
Hide resolved
serhiy-storchaka
approved these changes
Sep 7, 2021
…23.8Eh9iI.rst Co-authored-by: Dennis Sweeney <[email protected]>
Contributor
|
Thanks @1st1 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-28199 is a backport of this pull request to the 3.10 branch. |
pablogsal
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2021
…H-28194) Fix PyAiter_Check to only check for the `__anext__` presense (not for `__aiter__`). Rename `PyAiter_Check()` to `PyAIter_Check()`, `PyObject_GetAiter()` -> `PyObject_GetAIter()`. Co-authored-by: Pablo Galindo Salgado <[email protected]> (cherry picked from commit 2c3474a) Co-authored-by: Yury Selivanov <[email protected]>
pablogsal
pushed a commit
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PyAiter_Check to only check for the
__anext__presense (not for__aiter__). RenamePyAiter_Check()toPyAIter_Check(),PyObject_GetAiter()->PyObject_GetAIter().https://bugs.python.org/issue45123
Automerge-Triggered-By: GH:pablogsal