Skip to content

bpo-43693 Get rid of CO_NOFREE -- it's unused #26839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2021
Merged

bpo-43693 Get rid of CO_NOFREE -- it's unused #26839

merged 4 commits into from
Jun 23, 2021

Conversation

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jun 21, 2021 •
edited by bedevere-bot
Loading

All uses of this flag are either setting it or in doc or tests for it. So we should be able to get rid of it completely.

https://bugs.python.org/issue43693

@gvanrossum
Get rid of CO_NOFREE -- it's unused
3abad5f 
All uses of this flag are either setting it
or in doc or tests for it. So we should be
able to get rid of it completely.
@gvanrossum gvanrossum requested a review from markshannon as a code owner June 21, 2021 22:30
@markshannon
Copy link
Member

markshannon commented Jun 23, 2021

I see you've skipped the news item. I've made https://bugs.python.org/issue44500 to remind us to document all these changes.

markshannon
markshannon approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@gvanrossum gvanrossum merged commit 769d7d0 into python:main Jun 23, 2021
@gvanrossum gvanrossum deleted the drop-nofree-flag branch June 23, 2021 16:51
@markshannon markshannon mentioned this pull request May 2, 2022
Closed
2elli added a commit to 2elli/python-xdis that referenced this pull request Aug 15, 2023
@2elli
remove NOFREE flag in code info test
dfcf1ad 
Python 3.11 removes this flag, see python/cpython#26839
2elli added a commit to 2elli/python-xdis that referenced this pull request Aug 15, 2023
@2elli
remove use of NOFREE flag when testing >= 3.11
06299f3 
Python 3.11 removes this flag, see python/cpython#26839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gvanrossum @markshannon @the-knights-who-say-ni @bedevere-bot