Skip to content

gh-74902: add unicode grapheme cluster break algorithm #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

gh-74902: add unicode grapheme cluster break algorithm #2673

wants to merge 9 commits into from

Conversation

@Vermeille
Copy link

@Vermeille Vermeille commented Jul 11, 2017 •
edited by bedevere-bot
Loading

I have added GraphemeBreakProperty to UnicodeData.
An automaton to compute the rules for breaking grapheme clusters according to TR29 is included. It passes all the tests provided in GraphemeBreakTests.txt.

https://bugs.python.org/issue30717

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jul 11, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Vermeille Vermeille changed the title WIP: add grapheme cluster break algorithm bpo-30717: WIP: add grapheme cluster break algorithm Jul 11, 2017
@Vermeille Vermeille force-pushed the grapheme_cluster_break branch from 0f82f82 to 62fd6e0 Compare July 13, 2017 23:29
@Vermeille Vermeille changed the title bpo-30717: WIP: add grapheme cluster break algorithm bpo-30717: add grapheme cluster break algorithm Jul 14, 2017
@Vermeille Vermeille changed the title bpo-30717: add grapheme cluster break algorithm bpo-30717: add unicode grapheme cluster break algorithm Jul 14, 2017
@Vermeille Vermeille force-pushed the grapheme_cluster_break branch from 62fd6e0 to a47de54 Compare July 14, 2017 03:21
@Vermeille
Copy link
Author

Vermeille commented Aug 2, 2017

Hello? Someone here?

serhiy-storchaka
serhiy-storchaka reviewed Aug 3, 2017
View reviewed changes
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Aug 3, 2017
methane
methane requested changes Aug 3, 2017
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Aug 3, 2017
View reviewed changes
Modules/unicodedata.c Outdated
0, /*tp_setattro*/
0, /*tp_as_buffer*/
Py_TPFLAGS_DEFAULT,
"Internal grapheme cluster iterator object.", /* tp_doc */
Copy link
Member

@serhiy-storchaka serhiy-storchaka Aug 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the words "internal" and "object" are redundant.

Copy link
Author

@Vermeille Vermeille Aug 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Internal", "iterator" and "object" are all redundant. "Grapheme cluster iterator" seems just right. What do you think?

@Vermeille
Copy link
Author

Vermeille commented Jan 11, 2018

Sorry for the long wait.

Are we good concerning the changes? Anything to add?

@brettcannon
Copy link
Member

brettcannon commented Feb 2, 2018

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

@csabella
Copy link
Contributor

csabella commented May 23, 2020

@Vermeille, please take a look at the most recent comments on the bug tracker for this issue. It looks like the suggested path forward is different than the solution you proposed here. Thanks!

@github-actions
Copy link

github-actions bot commented Feb 20, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 20, 2022
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Aug 29, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 29, 2022
@arhadthedev arhadthedev changed the title bpo-30717: add unicode grapheme cluster break algorithm gh-74902: add unicode grapheme cluster break algorithm Feb 14, 2023
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 15, 2023
@github-actions
Copy link

github-actions bot commented Mar 18, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@methane methane methane requested changes

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Vermeille @the-knights-who-say-ni @brettcannon @csabella @methane @serhiy-storchaka @ezio-melotti