Skip to content

[3.6] bpo-30891: Fix importlib _find_and_load() race condition (#2646) #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2017
Merged

[3.6] bpo-30891: Fix importlib _find_and_load() race condition (#2646) #2651

merged 1 commit into from
Jul 10, 2017

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jul 10, 2017

  • Rewrite importlib _get_module_lock(): it is now responsible to hold
    the imp lock directly.
  • _find_and_load() now holds the module lock to check if name is in
    sys.modules to prevent a race condition
    (cherry picked from commit 4f9a446)

@vstinner
bpo-30891: Fix importlib _find_and_load() race condition (#2646)
9a4d781 
* Rewrite importlib _get_module_lock(): it is now responsible to hold
  the imp lock directly.
* _find_and_load() now holds the module lock to check if name is in
  sys.modules to prevent a race condition
(cherry picked from commit 4f9a446)
@vstinner vstinner merged commit fe6e686 into python:3.6 Jul 10, 2017
@vstinner vstinner deleted the importlib_module_lock36 branch July 10, 2017 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @the-knights-who-say-ni