Skip to content

[3.6] bpo-44022: Fix http client infinite line reading (DoS) after a HTTP 100 Continue (GH-25916) #25935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2021
Merged

[3.6] bpo-44022: Fix http client infinite line reading (DoS) after a HTTP 100 Continue (GH-25916) #25935

merged 1 commit into from
May 6, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 5, 2021 •
edited by bedevere-bot
Loading

Fixes http.client potential denial of service where it could get stuck reading lines from a malicious server after a 100 Continue response.

Co-authored-by: Gregory P. Smith [email protected]
(cherry picked from commit 47895e3)

Co-authored-by: Gen Xu [email protected]

https://bugs.python.org/issue44022

@gen-xu @miss-islington
bpo-44022: Fix http client infinite line reading (DoS) after a HTTP 1…
f7fb35b 
…00 Continue (pythonGH-25916)

Fixes http.client potential denial of service where it could get stuck reading lines from a malicious server after a 100 Continue response.

Co-authored-by: Gregory P. Smith <[email protected]>
(cherry picked from commit 47895e3)

Co-authored-by: Gen Xu <[email protected]>
@miss-islington
Copy link
Contributor Author

@gen-xu and @gpshead: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label May 5, 2021
@bedevere-bot bedevere-bot mentioned this pull request May 5, 2021
Merged
@gpshead gpshead added the type-security A security issue label May 5, 2021
@miss-islington
Copy link
Contributor Author

@gen-xu and @gpshead: Status check is done, and it's a failure ❌ .

@gpshead
Copy link
Member

gpshead commented May 5, 2021

that failure is unrelated.

@ned-deily
Copy link
Member

Yeah, don't worry about it. I'll test and merge the PR soon-ish. Thanks!

@ned-deily ned-deily merged commit f68d2d6 into python:3.6 May 6, 2021
@miss-islington miss-islington deleted the backport-47895e3-3.6 branch May 6, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@ned-deily ned-deily

Labels

type-bug An unexpected behavior, bug, or error type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miss-islington @gpshead @ned-deily @the-knights-who-say-ni @bedevere-bot @gen-xu