Skip to content

bpo-43382: Pin test runner to Ubuntu 18 to un-break CI (for now) #24715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2021
Merged

bpo-43382: Pin test runner to Ubuntu 18 to un-break CI (for now) #24715

merged 1 commit into from
Mar 3, 2021

Conversation

@brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Mar 3, 2021 •
edited
Loading

Feel free to merge if there's any consensus. I'm going to sleep.

Also, should this be backported to 3.9 / 3.8 / 3.7? Probably, right?

https://bugs.python.org/issue43382

@brandtbucher brandtbucher added tests Tests in the Lib/test dir skip news labels Mar 3, 2021
@brandtbucher brandtbucher self-assigned this Mar 3, 2021
@brandtbucher brandtbucher removed their assignment Mar 3, 2021
@nascheme nascheme merged commit 94894dd into python:master Mar 3, 2021
@bedevere-bot
Copy link

bedevere-bot commented Mar 3, 2021

@nascheme: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Mar 3, 2021

Thanks @brandtbucher for the PR, and @nascheme for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 3, 2021

Thanks @brandtbucher for the PR, and @nascheme for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 3, 2021

Thanks @brandtbucher for the PR, and @nascheme for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Mar 3, 2021

GH-24716 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2021
@brandtbucher @miss-islington
Pin test runner to Ubuntu 18 to un-break CI (pythonGH-24715)
568ac3f 
(cherry picked from commit 94894dd)

Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Mar 3, 2021

GH-24717 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2021
@brandtbucher @miss-islington
Pin test runner to Ubuntu 18 to un-break CI (pythonGH-24715)
e05a9cf 
(cherry picked from commit 94894dd)

Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Mar 3, 2021

GH-24718 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2021
@brandtbucher @miss-islington
Pin test runner to Ubuntu 18 to un-break CI (pythonGH-24715)
ce051dd 
(cherry picked from commit 94894dd)

Co-authored-by: Brandt Bucher <[email protected]>
@miss-islington
Copy link
Contributor

miss-islington commented Mar 3, 2021

Thanks @brandtbucher for the PR, and @nascheme for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 3, 2021

Sorry, @brandtbucher and @nascheme, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 94894dd45e4bad6efb27eac4497b24cdc18b3e2d 3.6

@tiran
Copy link
Member

tiran commented Mar 3, 2021

3.6 branch does not use GHA.

miss-islington added a commit that referenced this pull request Mar 3, 2021
@miss-islington @brandtbucher
Pin test runner to Ubuntu 18 to un-break CI (GH-24715)
024325d 
(cherry picked from commit 94894dd)

Co-authored-by: Brandt Bucher <[email protected]>
miss-islington added a commit that referenced this pull request Mar 3, 2021
@miss-islington
[3.8] Pin test runner to Ubuntu 18 to un-break CI (GH-24715) (GH-24717)
9c6c5da 
(cherry picked from commit 94894dd)


Co-authored-by: Brandt Bucher <[email protected]>

Automerge-Triggered-By: GH:tiran
ned-deily pushed a commit that referenced this pull request Mar 3, 2021
@miss-islington @brandtbucher
Pin test runner to Ubuntu 18 to un-break CI (GH-24715) (GH-24716)
a99860e 
(cherry picked from commit 94894dd)

Co-authored-by: Brandt Bucher <[email protected]>

Co-authored-by: Brandt Bucher <[email protected]>
@brandtbucher brandtbucher deleted the fix-ci branch July 21, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nascheme nascheme

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brandtbucher @bedevere-bot @miss-islington @tiran @nascheme @the-knights-who-say-ni