[3.9] bpo-40686: Fix compiler warnings on _zoneinfo.c (GH-23614) #23804
Conversation
"uint8_t day" is unsigned and so "day < 0" test is always true. Remove the test to fix the following warnings on Windows: modules\_zoneinfo.c(1224): warning C4068: unknown pragma modules\_zoneinfo.c(1225): warning C4068: unknown pragma modules\_zoneinfo.c(1227): warning C4068: unknown pragma (cherry picked from commit aefb69b) Co-authored-by: Victor Stinner <[email protected]>
|
@vstinner: Status check is done, and it's a success ✅ . |
pganssle
left a comment
pganssle
left a comment
There was a problem hiding this comment.
This was wrongly merged in the first place.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@vstinner: Status check is done, and it's a success ✅ . |
|
This is a backport of a change which has been approved. This backport is not the right place to continue the discussion. Since you created https://bugs.python.org/issue42660, I suggest to continue the discussion there. As I wrote in the parent PR, there is room for enhancement, but this change is a practical fix for https://bugs.python.org/issue40686 |
5 participants
"uint8_t day" is unsigned and so "day < 0" test is always true.
Remove the test to fix the following warnings on Windows:
modules_zoneinfo.c(1224): warning C4068: unknown pragma
modules_zoneinfo.c(1225): warning C4068: unknown pragma
modules_zoneinfo.c(1227): warning C4068: unknown pragma
(cherry picked from commit aefb69b)
Co-authored-by: Victor Stinner [email protected]
https://bugs.python.org/issue40686