Skip to content

[Trivial] Add source code links for asyncio submodules in docs #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2017
Merged

[Trivial] Add source code links for asyncio submodules in docs #2373

merged 1 commit into from
Jul 25, 2017

Conversation

@lf-
Copy link
Contributor

@lf- lf- commented Jun 24, 2017

The modules under asyncio were lacking links to their source. This pull request fixes this (and a double space typo in one of the pages' headers).

@mention-bot
Copy link

mention-bot commented Jun 24, 2017

@lf-, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1st1, @berkerpeksag and @serhiy-storchaka to be potential reviewers.

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jun 24, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@lf-
Copy link
Contributor Author

lf- commented Jun 24, 2017

CLA signed, waiting on approval.

@lf- lf- changed the title Add source code links for asyncio submodules in docs [Trivial] Add source code links for asyncio submodules in docs Jun 24, 2017
@Mariatta Mariatta added topic-asyncio trivial docs Documentation in the Doc dir labels Jun 27, 2017
@Mariatta Mariatta merged commit 627d2c8 into python:master Jul 25, 2017
@Mariatta
Copy link
Member

Mariatta commented Jul 25, 2017

Thanks @lf- and congrats on your first contribution to CPython 🎉

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jul 26, 2017
@lf- @Mariatta
[3.6] Add the link to asyncio source code in the docs (pythonGH-2373)
d53fd43 
(cherry picked from commit 627d2c8)
@bedevere-bot
Copy link

bedevere-bot commented Jul 26, 2017

GH-2884 is a backport of this pull request to the 3.6 branch.

Mariatta added a commit that referenced this pull request Jul 26, 2017
@Mariatta
Add the link to asyncio source code in the docs (GH-2373) (GH-2884)
0dbfab2 
(cherry picked from commit 627d2c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lf- @mention-bot @the-knights-who-say-ni @Mariatta @bedevere-bot @brettcannon