Skip to content

Conversation

@hiqua
Copy link
Contributor

@hiqua hiqua commented Nov 20, 2020

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@vstinner
Copy link
Member

@hiqua: Please sign the Python CLA.

@hiqua
Copy link
Contributor Author

hiqua commented Nov 20, 2020

@vstinner I did when I opened this PR, I can only wait for the confirmation from the PSF now.

@vstinner
Copy link
Member

@vstinner I did when I opened this PR, I can only wait for the confirmation from the PSF now.

Ok, perfect. It can take a few days (especially with the long week day). Ping me next week, so I can try to remove the label, to see when it's done. In the meanwhile, you can check https://bugs.python.org/user36585 to see when "Contributor Form Received" is switched to Yes ;-)

@terryjreedy terryjreedy merged commit aa3a352 into python:master Nov 21, 2020
@miss-islington
Copy link
Contributor

Thanks @hiqua for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 21, 2020
@bedevere-bot
Copy link

GH-23435 is a backport of this pull request to the 3.9 branch.

@python python deleted a comment from the-knights-who-say-ni Nov 21, 2020
@terryjreedy
Copy link
Member

A typo fix does not require CLA as there is no creative content in the fix. And it is Friday night, so I merged.

Quentin, thanks. We hope to see more from you, perhaps something that does require the CLA, so please follow up.

terryjreedy pushed a commit that referenced this pull request Nov 21, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants