bpo-41970: Avoid test failure in test_lib2to3 if the module is already imported #22595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
added
🤖 automerge
and removed
awaiting core review
tests
tirkarthi
approved these changes
Oct 8, 2020
Member
tirkarthi
left a comment
tirkarthi
left a comment
There was a problem hiding this comment.
LGTM. Thanks @pablogsal, on further thought this seems to be a better approach testing warning is raised than passing quiet=True. quiet=True won't catch even if the warning is removed though we will be removing lib2to3 in future. I tested the patch and it works fine locally.
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Sorry, @pablogsal, I could not cleanly backport this to |
Member
Author
|
@tirkarthi Could you do the 3.9 backport? |
Member
|
Sure, I will do it. |
tirkarthi
pushed a commit
to tirkarthi/cpython
that referenced
this pull request
Oct 9, 2020
…already imported (pythonGH-22595) … Automerge-Triggered-By: @pablogsal. (cherry picked from commit 4a9f82f) Co-authored-by: Pablo Galindo <[email protected]>
|
GH-22609 is a backport of this pull request to the 3.9 branch. |
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Oct 9, 2020
* origin/master: (147 commits) Fix the attribute names in the docstring of GenericAlias (pythonGH-22594) bpo-39337: Add a test case for normalizing of codec names (pythonGH-19069) bpo-41557: Update Windows installer to use SQLite 3.33.0 (pythonGH-21960) bpo-41976: Fix the fallback to gcc of ctypes.util.find_library when using gcc>9 (pythonGH-22598) bpo-41306: Allow scale value to not be rounded (pythonGH-21715) bpo-41970: Avoid test failure in test_lib2to3 if the module is already imported (pythonGH-22595) bpo-41376: Fix the documentation of `site.getusersitepackages()` (pythonGH-21602) Revert "bpo-26680: Incorporate is_integer in all built-in and standard library numeric types (pythonGH-6121)" (pythonGH-22584) bpo-41923: PEP 613: Add TypeAlias to typing module (python#22532) Fix comment about PyObject_IsTrue. (pythonGH-22343) bpo-38605: Make 'from __future__ import annotations' the default (pythonGH-20434) bpo-41905: Add abc.update_abstractmethods() (pythonGH-22485) bpo-41944: No longer call eval() on content received via HTTP in the UnicodeNames tests (pythonGH-22575) bpo-41944: No longer call eval() on content received via HTTP in the CJK codec tests (pythonGH-22566) Post 3.10.0a1 Python 3.10.0a1 bpo-41584: clarify when the reflected method of a binary arithemtic operator is called (python#22505) bpo-41939: Fix test_site.test_license_exists_at_url() (python#22559) bpo-41774: Tweak new programming FAQ entry (pythonGH-22562) bpo-41936. Remove macros Py_ALLOW_RECURSION/Py_END_ALLOW_RECURSION (pythonGH-22552) ...
pablogsal
added a commit
that referenced
this pull request
Oct 9, 2020
…already imported (GH-22595) (GH-22609) (cherry picked from commit 4a9f82f) Co-authored-by: Pablo Galindo <[email protected]>
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
…y imported (pythonGH-22595) … Automerge-Triggered-By: @pablogsal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
https://bugs.python.org/issue41970
Automerge-Triggered-By: @pablogsal