bpo-41576: document BaseException in favor of bare except #21917
Conversation
graingert
changed the title
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
To me, the change improves this section.
graingert
changed the title
|
|
||
| After the statement is executed, the file *f* is always closed, even if a | ||
| problem was encountered while processing the lines. Objects which, like files, | ||
| provide predefined clean-up actions will indicate this in their documentation. |
There was a problem hiding this comment.
My editor keeps trimming this buggy whitespace, so we should probably remove it anyway
|
@terryjreedy what's the next step here? |
|
I am looking at this and will request or make some changes. I need to look at the context and think of how to answer Serhiy's objection on the issue. |
|
@terryjreedy I've now fixed the conflicts in this PR |
|
Thanks @graingert for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
Sorry, @graingert and @ambv, I could not cleanly backport this to |
|
GH-27646 is a backport of this pull request to the 3.10 branch. |
…1917) (cherry picked from commit e9a6f1b) Co-authored-by: Thomas Grainger <[email protected]>
(cherry picked from commit e9a6f1b) Co-authored-by: Thomas Grainger <[email protected]>
|
@ambv Thanks for finishing this. |
6 participants
https://bugs.python.org/issue41576