Skip to content

bpo-41486: Add _BlocksOutputBuffer for bz2/lzma/zlib modules #21740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from Apr 28, 2021
Merged

bpo-41486: Add _BlocksOutputBuffer for bz2/lzma/zlib modules #21740

merged 18 commits into from Apr 28, 2021

Conversation

@ghost
Copy link

@ghost ghost commented Aug 5, 2020 •
edited by ghost
Loading

And add .readall() function to _compression.DecompressReader class.

Oct 16, 2020 update: No compiler warnings.

https://bugs.python.org/issue41486

@taleinat taleinat added the performance Performance or resource usage label Oct 25, 2020
taleinat
taleinat reviewed Oct 25, 2020
View reviewed changes
methane
methane reviewed Oct 26, 2020
View reviewed changes
gpshead
gpshead requested changes Apr 11, 2021
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Apr 11, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ghost
Copy link
Author

ghost commented Apr 12, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Apr 12, 2021

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from gpshead April 12, 2021 02:01
@ghost
Copy link
Author

ghost commented Apr 12, 2021

This commit Merge branch 'master' into blocks_output_buffer solved code conflict in Doc/whatsnew/3.10.rst, so it's empty.

gpshead
gpshead requested changes Apr 28, 2021
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great code! one unused bit of code to delete and a few assertions on constants that i think can be compile time errors instead?

this is ready to go in after that.

@bedevere-bot
Copy link

bedevere-bot commented Apr 28, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ghost
Copy link
Author

ghost commented Apr 28, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Apr 28, 2021

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from gpshead April 28, 2021 05:54
@gpshead gpshead merged commit f9bedb6 into python:master Apr 28, 2021
@gpshead gpshead self-assigned this Apr 28, 2021
@gpshead gpshead added the type-feature A feature request or enhancement label Apr 28, 2021
@ghost ghost deleted the blocks_output_buffer branch May 1, 2021 05:18
@rhpvorderman rhpvorderman mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gpshead gpshead

Labels

performance Performance or resource usage type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bedevere-bot @gpshead @methane @taleinat @the-knights-who-say-ni @wjssz