Skip to content

bpo-41112: Fix test_peg_generator on non-UTF-8 locales. #21138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2020
Merged

bpo-41112: Fix test_peg_generator on non-UTF-8 locales. #21138

merged 1 commit into from
Jun 25, 2020

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 25, 2020 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added needs backport to 3.8 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jun 25, 2020
@bedevere-bot
Copy link

bedevere-bot commented Jun 25, 2020

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit dd764ec 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 25, 2020
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jun 25, 2020
@pablogsal
Copy link
Member

pablogsal commented Jun 25, 2020

Thanks for the fix, @serhiy-storchaka !

@serhiy-storchaka serhiy-storchaka merged commit aad8f0e into python:master Jun 25, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jun 25, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the test_peg_generator branch June 25, 2020 11:31
@miss-islington
Copy link
Contributor

miss-islington commented Jun 25, 2020

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker aad8f0eeca93b2150760b5e59ed0495e47d1be1e 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Jun 25, 2020

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker aad8f0eeca93b2150760b5e59ed0495e47d1be1e 3.8

@lysnikolaou
Copy link
Member

lysnikolaou commented Jun 25, 2020

This should not be backported to 3.8, so I'm removing that label.

@miss-islington
Copy link
Contributor

miss-islington commented Jun 25, 2020

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 25, 2020
@serhiy-storchaka @miss-islington
bpo-41112: Fix test_peg_generator on non-UTF-8 locales. (pythonGH-21138)
0fefd12 
(cherry picked from commit aad8f0e)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jun 25, 2020

GH-21150 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jun 25, 2020
@miss-islington @serhiy-storchaka
bpo-41112: Fix test_peg_generator on non-UTF-8 locales. (GH-21138)
c4dfcb2 
(cherry picked from commit aad8f0e)

Co-authored-by: Serhiy Storchaka <[email protected]>
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@serhiy-storchaka @fasihahmad
bpo-41112: Fix test_peg_generator on non-UTF-8 locales. (pythonGH-21138)
f72fe0e
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @bedevere-bot @pablogsal @miss-islington @lysnikolaou @the-knights-who-say-ni