bpo-40745: Fix typos in NewType docs #20379
Conversation
Doc/library/typing.rst
Outdated
| ``List[ForwardRef("SomeClass")]``. This class should not be instantiated by | ||
| a user, but may be used by introspection tools. | ||
|
|
||
| .. function:: NewType(typ) |
There was a problem hiding this comment.
It looks like the function signature for NewType doesn't match the examples since they call it with two parameters, but there's only one here. Can you also add that in this patch? Thanks!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
LG. Why did you change ‘typ’ to ‘tp’?
gvanrossum
changed the title
|
|
Thanks @zihengCat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
(cherry picked from commit 2b0e654) Co-authored-by: ziheng <[email protected]>
|
GH-20410 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit 2b0e654) Co-authored-by: ziheng <[email protected]>
|
GH-20411 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit 2b0e654) Co-authored-by: ziheng <[email protected]>
(cherry picked from commit 2b0e654) Co-authored-by: ziheng <[email protected]>
7 participants
https://bugs.python.org/issue40745
Automerge-Triggered-By: @gvanrossum