bpo-40683: Add zoneinfo to LIBSUBDIRS #20229
Conversation
Without this, only the _zoneinfo module is getting installed, not the zoneinfo module. I believe this was not noticed earlier because test.test_zoneinfo was also not being installed.
pganssle
force-pushed
the
include_zoneinfo
branch
from
5ae6d36 to
0b72dc4
Compare
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM with a nitpick comment :-D
| curses pydoc_data \ | ||
| zoneinfo |
There was a problem hiding this comment.
nitpick:
| curses pydoc_data \ | |
| zoneinfo | |
| curses pydoc_data zoneinfo |
There was a problem hiding this comment.
What's the rule here? I don't know what pydoc_data is, but it seems like everything else is separated along conceptual lines (unittest stuff by itself, venv stuff by itself, asyncio by itself, etc).
There was a problem hiding this comment.
There is no rule. Only personal perferences. I would expect sorting, but it seems like we lost that long time ago.
There was a problem hiding this comment.
You're free to ignore my coding-style comment ;-)
There was a problem hiding this comment.
OK, I think I prefer it to be separated conceptually. Would be good to actually have a rule at some point (maybe with an autoformatter). I'm going to go ahead and merge.
|
@pganssle: Please replace |
|
Thanks @pganssle for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-20230 is a backport of this pull request to the 3.9 branch. |
Without this, only the _zoneinfo module is getting installed, not the zoneinfo module. I believe this was not noticed earlier because test.test_zoneinfo was also not being installed. (cherry picked from commit 2abeded) Co-authored-by: Paul Ganssle <[email protected]>
Without this, only the _zoneinfo module is getting installed, not the zoneinfo module. I believe this was not noticed earlier because test.test_zoneinfo was also not being installed.
5 participants
Without this, only the
_zoneinfomodule is getting installed, not thezoneinfomodule. I believe this was not noticed earlier becausetest.test_zoneinfowas also not being installed.With this fix, the tests are passing correctly locally:
https://bugs.python.org/issue40683