Skip to content

bpo-39943: Remove unused arg from find_nfc_index() #18973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2020
Merged

bpo-39943: Remove unused arg from find_nfc_index() #18973

merged 1 commit into from
Mar 17, 2020

Conversation

@petdance
Copy link
Contributor

@petdance petdance commented Mar 13, 2020 •
edited by bedevere-bot
Loading

Remove unused arg from find_nfc_index()

https://bugs.python.org/issue39943

corona10
corona10 approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petdance Nice catch!
How did you find it?

@corona10 corona10 requested a review from vstinner March 17, 2020 09:35
@petdance
Copy link
Contributor Author

petdance commented Mar 17, 2020

Thanks. I used GCC's -Wunused-parameter option and waded through all the false positives.

It would be nice if we could have -Wunused-parameter on by default, but there are so many API methods that pass unnecessary parameters, it would make too much noise. Either that, or we'd have to mark every unused parameter with Py_UNUSED, but that would be pretty ugly.

@corona10
Copy link
Member

corona10 commented Mar 17, 2020

@petdance Nice!

@vstinner vstinner merged commit 982307b into python:master Mar 17, 2020
@petdance
Copy link
Contributor Author

petdance commented Mar 17, 2020

Thanks for merging this, @vstinner. Now I can refork my repo to get rid of whatever weird commits I have that caused problems before.

@petdance petdance deleted the bpo-39943-Modules-unicodedata-B branch March 17, 2020 16:59
@petdance petdance mannequin mentioned this pull request May 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petdance @corona10 @vstinner @the-knights-who-say-ni @bedevere-bot