Skip to content

bpo-38344 else needs to be on the same line as the if #16533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 7, 2019
Merged

bpo-38344 else needs to be on the same line as the if #16533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c7cf323
else needs to be on the same line as the if
jamesabel Oct 2, 2019
51dd606
Update activate.bat
jamesabel Oct 2, 2019
3a2f45f
use if not defined instead of else
jamesabel Oct 5, 2019
3ac7bbb
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 5, 2019
8800e20
remove quotes
jamesabel Oct 7, 2019
fd0f417
Update 2019-10-05-05-50-58.bpo-38344.scr2LO.rst
jamesabel Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/venv/scripts/nt/activate.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ if defined PYTHONHOME set _OLD_VIRTUAL_PYTHONHOME=%PYTHONHOME%
set PYTHONHOME=

if defined _OLD_VIRTUAL_PATH set PATH=%_OLD_VIRTUAL_PATH%
else set _OLD_VIRTUAL_PATH=%PATH%
Copy link
Member

@zooba zooba Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the old syntax and replace the else with if not defined ....

if not defined _OLD_VIRTUAL_PATH set _OLD_VIRTUAL_PATH=%PATH%

set PATH=%VIRTUAL_ENV%\__VENV_BIN_NAME__;%PATH%

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Windows/2019-10-05-05-50-58.bpo-38344.scr2LO.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix error message in activate.bat