Skip to content

bpo-32631: IDLE: Enable zzdummy extension module #14491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2021
Merged

bpo-32631: IDLE: Enable zzdummy extension module #14491

merged 4 commits into from
Jan 5, 2021

Conversation

@csabella
Copy link
Contributor

@csabella csabella commented Jul 1, 2019 •
edited by bedevere-bot
Loading

  • Complete functionality to add or remove prefix string to each line.
  • Add comments and docstrings to zzdummy.
  • Add unittests in test_zzdummy.
  • Add help section for extensions tab to configdialog.

https://bugs.python.org/issue32631

@csabella csabella requested a review from terryjreedy as a code owner July 1, 2019 00:45
@brettcannon brettcannon added the type-feature A feature request or enhancement label Jul 5, 2019
@csabella
bpo-32631: IDLE: Enable zzdummy extension module
8ea79ec 
* Complete functionality to add or remove prefix string to each line.
* Add comments and docstrings to zzdummy.
* Add unittests in test_zzdummy.
* Add help section for extensions tab to configdialog.
@csabella csabella requested a review from taleinat June 20, 2020 13:09
terryjreedy
terryjreedy approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the behavior is not exactly what I intended (see issue), the example now works as an example. Approved with my minor doc changes. Will merge when retest passes.

@terryjreedy
Copy link
Member

terryjreedy commented Jan 5, 2021 •
edited by bedevere-bot
Loading

The Travis and Pipelines failures are only due to bad markup in the News item for bpo-40810, just fixed by #24110 and backports. I restarted Travis and it passed. Cannot restart Pipelines, so ignoring.

@terryjreedy terryjreedy merged commit e40e2a2 into python:master Jan 5, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Sorry @csabella and @terryjreedy, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e40e2a2cc94c554e7e245a8ca5a7432d31a95766 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Sorry, @csabella and @terryjreedy, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e40e2a2cc94c554e7e245a8ca5a7432d31a95766 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Sorry @csabella and @terryjreedy, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e40e2a2cc94c554e7e245a8ca5a7432d31a95766 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Sorry, @csabella and @terryjreedy, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e40e2a2cc94c554e7e245a8ca5a7432d31a95766 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Sorry @csabella and @terryjreedy, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e40e2a2cc94c554e7e245a8ca5a7432d31a95766 3.9

terryjreedy pushed a commit to terryjreedy/cpython that referenced this pull request Jan 5, 2021
@csabella @terryjreedy
[3.9] bpo-32631: IDLE: Enable zzdummy example extension module (pytho…
0458ff1 
…nGH-14491)

Make menu items work with formatter, add docstrings, add 100% tests.

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit e40e2a2)

Co-authored-by: Cheryl Sabella <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jan 5, 2021

GH-24114 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 5, 2021

Sorry, @csabella and @terryjreedy, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e40e2a2cc94c554e7e245a8ca5a7432d31a95766 3.8

terryjreedy added a commit that referenced this pull request Jan 5, 2021
@terryjreedy @csabella
[3.9] bpo-32631: IDLE: Enable zzdummy example extension module (GH-14491
d82392f 
)

Make menu items work with formatter, add docstrings, add 100% tests.

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit e40e2a2)

Co-authored-by: Cheryl Sabella <[email protected]>
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jan 5, 2021
@terryjreedy
bpo-32631: IDLE: Enable zzdummy example extension module (pythonGH-14491
c330f30 
)

Make menu items work with formatter, add docstrings, add 100% tests.

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit e40e2a2)
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jan 5, 2021
@terryjreedy @csabella
[3.8] bpo-32631: IDLE: Enable zzdummy example extension module (pytho…
0e90dc0 
…nGH-14491)

Make menu items work with formatter, add docstrings, add 100% tests.

Co-authored-by: Terry Jan Reedy <[email protected]>.
(cherry picked from commit e40e2a2)

Co-authored-by: Cheryl Sabella <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jan 5, 2021

GH-24115 is a backport of this pull request to the 3.8 branch.

terryjreedy added a commit that referenced this pull request Jan 5, 2021
@terryjreedy @csabella
[3.8] bpo-32631: IDLE: Enable zzdummy example extension module (GH-14491
a087a97 
)

Make menu items work with formatter, add docstrings, add 100% tests.

Co-authored-by: Cheryl Sabella <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit e40e2a2)
@csabella csabella deleted the bpo32631 branch January 22, 2021 13:26
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@csabella @terryjreedy @adorilson
bpo-32631: IDLE: Enable zzdummy example extension module (pythonGH-14491
cb53974 
)

Make menu items work with formatter, add docstrings, add 100% tests.

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

@taleinat taleinat Awaiting requested review from taleinat

Assignees

@terryjreedy terryjreedy

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@csabella @terryjreedy @miss-islington @bedevere-bot @brettcannon @the-knights-who-say-ni