bpo-30345: travis: use -Og cflags with --with-pydebug #14423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested changes
Jun 27, 2019
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
There are 3 ./configure calls in .travis.yml. Either update them all, or set -Og in global CFLAGS.
|
When you're done making the requested changes, leave the comment: |
Member
Author
-Og is useful only when running test_gdb. |
vstinner
approved these changes
Jun 27, 2019
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Almost, sorry. I misread .travis.yml. So your change LGTM.
Contributor
|
Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 27, 2019
(cherry picked from commit 21cfae1) Co-authored-by: Inada Naoki <[email protected]>
|
GH-14427 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 27, 2019
(cherry picked from commit 21cfae1) Co-authored-by: Inada Naoki <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30345