bpo-37400: Fix test_os.test_chown() #14374
Merged
+10
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use os.getgroups() rather than grp.getgrall() to get groups. Rename also the test to test_chown_gid().
Member
Author
|
Oh, grp.getgrall() was used, not pwd.getpwall(). I updated my PR. |
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 25, 2019
Use os.getgroups() rather than grp.getgrall() to get groups. Rename also the test to test_chown_gid(). (cherry picked from commit d7c87d9) Co-authored-by: Victor Stinner <[email protected]>
|
GH-14377 is a backport of this pull request to the 3.8 branch. |
|
GH-14378 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 25, 2019
Use os.getgroups() rather than grp.getgrall() to get groups. Rename also the test to test_chown_gid(). (cherry picked from commit d7c87d9) Co-authored-by: Victor Stinner <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 25, 2019
Use os.getgroups() rather than grp.getgrall() to get groups. Rename also the test to test_chown_gid(). (cherry picked from commit d7c87d9) Co-authored-by: Victor Stinner <[email protected]>
vstinner
added a commit
that referenced
this pull request
Jun 25, 2019
Use os.getgroups() rather than grp.getgrall() to get groups. Rename also the test to test_chown_gid(). (cherry picked from commit d7c87d9) Co-authored-by: Victor Stinner <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
Use os.getgroups() rather than grp.getgrall() to get groups. Rename also the test to test_chown_gid().
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Use os.getgroups() rather than grp.getgrall() to get groups. Rename also the test to test_chown_gid().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use os.getgroups() rather than pwd.getpwall() to get groups.
Rename also test_chown() to test_chown_gid().
https://bugs.python.org/issue37400