bpo-37382: check for debug info before testing GDB #14331
Conversation
|
CC @encukou |
|
Bugfix, so should be backported to all earlier versions. |
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
The tests should be skipped if Python is optimized: see the issue.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
So how would you suggest to fix bpo-37382? |
|
https://bugs.python.org/issue37382 is not a bug. |
|
At least part of it is a bug: But the real issue for me is that |
encukou
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Please don't backport this change to Python 3.8 :-) test_gdb is giving me too many headaches :-) For example, it fails if Python is built with -Os.
| final_opt = "" | ||
| for opt in cflags.split(): | ||
| if opt.startswith('-g'): | ||
| final_opt = opt |
There was a problem hiding this comment.
Why not just returning True here? (and "return False" outside the loop)
| for opt in cflags.split(): | ||
| if opt.startswith('-g'): | ||
| final_opt = opt | ||
| return final_opt == '-g' |
There was a problem hiding this comment.
Why do you reject "-ggdb"? I heard that it's even better than "-g".
|
|
||
| .. function:: python_has_debug_info() | ||
|
|
||
| Return ``True`` if Python was built with ``-g``. |
|
Sorry for missing the ping back in 2019. |
6 participants
https://bugs.python.org/issue37382