gh-60107: Remove a copy from RawIOBase.read #141532
Open
+32
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the underlying I/O class keeps a reference to the memory raise BufferError.
cmaloney
commented
Nov 13, 2025
cmaloney
commented
Nov 13, 2025
| } | ||
| return res; | ||
| } | ||
| res = PyObject_CallMethod(b, "take_bytes", NULL); |
Contributor
Author
There was a problem hiding this comment.
@vstinner : Not sure how common this "resize/discard then take_bytes" is going to be; might make sense to change to take_bytes(n=None, /, *, discard=False)
Contributor
Author
There was a problem hiding this comment.
for now planning to keep that in back pocket until need many ways (ba.resize(n) or del ba[:n] gives the same capability)
vstinner
reviewed
Nov 15, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Can you also update RawIOBase.read() in the _pyio module?
Contributor
Author
|
Have that in #141539 which does all the cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the underlying I/O class keeps a reference to the memory raise
BufferError.Uses gh-139871 to implement.
--
If want to maintain closer compatibility when a
BufferErroroccurs can fall back to a copy (copying is as safe as the original code). I have a slight preference to erroring as I think keeping a reference to the memory is uncommon (and probably unintended).bytearraytobytesin rawiobase_read() implementation #60107