-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-140702: Add test skip for Unix Datagram tests on iOS when on Github Actions #140740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-140702: Add test skip for Unix Datagram tests on iOS when on Github Actions #140740
Conversation
Co-authored-by: Hugo van Kemenade <[email protected]>
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
… Github Actions (pythonGH-140740) Exposes the GITHUB_ACTIONS environment variable to iOS simulator test runs, and uses this variable to skip a Unix Datagram socketserver test that is unreliable in the iOS GitHub Actions environment. (cherry picked from commit 9f8d005) Co-authored-by: Russell Keith-Magee <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-140742 is a backport of this pull request to the 3.14 branch. |
…n Github Actions (GH-140740) (#140742) Exposes the GITHUB_ACTIONS environment variable to iOS simulator test runs, and uses this variable to skip a Unix Datagram socketserver test that is unreliable in the iOS GitHub Actions environment. (cherry picked from commit 9f8d005) Co-authored-by: Russell Keith-Magee <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
On GitHub Actions, it appears that the UnixDatagramServer tests are unstable on the iOS simulator.
This test has been running successfully on the buildbot for months; I think I've seen one failure in the last 6 months that might be the same cause.
I can't reproduce the failure locally. But it appears that on GitHub Actions, the test fails regularly. I have spent the day trying to work out why, without a whole lot of success - mostly because it can only be replicated on GitHub Actions. And given the problems that GitHub have been having with the macOS-15 runners for the last couple of months, it doesn't seem out of the question that there may be systemic problems with the platform that will be resolved with time.
This PR skips the 2 affected tests, but only on iOS simulator, when running on GitHub Actions. It exposes the GITHUB_ACTIONS variable to the running iOS app environment to make this possible.
I don't like this fix; but at this point, it seems the pragmatic option. The underlying test will still run on buildbots, and on individual tests.