Skip to content

gh-140228: Linecache source is unavailable for frozen modules when global modules is None #140377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2025
Merged

gh-140228: Linecache source is unavailable for frozen modules when global modules is None #140377

merged 3 commits into from
Oct 29, 2025

Conversation

@tconley1428
Copy link
Contributor

@tconley1428 tconley1428 commented Oct 20, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app
Copy link

bedevere-app bot commented Oct 20, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@python-cla-bot
Copy link

python-cla-bot bot commented Oct 20, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Oct 20, 2025
Closed
@gaogaotiantian
Copy link
Member

gaogaotiantian commented Oct 24, 2025

@tconley1428 you need to add news to it because it's changes the behavior.

@gaogaotiantian gaogaotiantian added the needs backport to 3.14 bugs and security fixes label Oct 24, 2025
@tconley1428
Copy link
Contributor Author

tconley1428 commented Oct 28, 2025

@gaogaotiantian done I think, though I'm not familiar with the process here.

@gaogaotiantian gaogaotiantian merged commit c41f84f into python:main Oct 29, 2025
46 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 29, 2025

Thanks @tconley1428 for the PR, and @gaogaotiantian for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 29, 2025
@tconley1428 @miss-islington
pythongh-140228: Avoid making unnecessary syscalls in linecache for f…
f946604 
…rozen modules (pythonGH-140377)

(cherry picked from commit c41f84f)

Co-authored-by: tconley1428 <[email protected]>
@gaogaotiantian
Copy link
Member

gaogaotiantian commented Oct 29, 2025

Thank you for your contribution and congrats to your first PR @tconley1428 !

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2025

GH-140738 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 29, 2025
gaogaotiantian pushed a commit that referenced this pull request Oct 29, 2025
@miss-islington @tconley1428
[3.14] gh-140228: Avoid making unnecessary syscalls in linecache for …
6d0e1c8 
…frozen modules (GH-140377) (#140738)

gh-140228: Avoid making unnecessary syscalls in linecache for frozen modules (GH-140377)
(cherry picked from commit c41f84f)

Co-authored-by: tconley1428 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tconley1428 @gaogaotiantian