-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-139588: Docs: PDF: convert SVG to PDF using sphinxcontrib.rsvgconverter #140342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This will install and use the extension for all builds, including HTML and others not building PDFs. Is that intentional? |
The extension is quite lightweight itself, 28.95 KB [1], and skips converting for builders other that LaTeX. I think that it's not worth to introduce handling of optional dependencies for docs builds because of it. [1] |
|
I'm also unsure about using another third-party extension. Could we not just use the latex customisation features to include the required LaTeX packages? A |
We can include |
involves bringing in a third-party dependency, who's code we haven't audited, etc. I will point out that until recently, no one had noticed the problem with this particular SVG file, which was added some months ago! A |
|
For the avoidance of doubt I'll close this PR, it isn't the right solution. A |
For what it's worth, in PL translation project we build PDFs for stable branches only, the SVG/PDF issue impacts main branch only. |
#133591 introduced an SVG into docs, which is not handled by LaTeX (used for PDF build) natively. This fixes the PDF build error. Uses a recommended approach.
(Better) alternative to #139635.
Render:
📚 Documentation preview 📚: https://cpython-previews--140342.org.readthedocs.build/