-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-139940: Handle RuntimeError when attaching to a non-existing process in pdb.py #139941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
I think attaching to a non-exist process is a common case where we should produce better error messages. I have a feeling that the message should be even more explicit about "you have the wrong process id". @pablogsal and @godlygeek what do you think? |
|
Sounds reasonable to me. Maybe we want to catch the RuntimeError on POSIX and handle it by attempting |
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
e4cf4cc to
c50b200
Compare
…cess Signed-off-by: Frost Ming <[email protected]>
3bcc075 to
3170ece
Compare
|
I think we can make a very simple test to test this addition - could you do it @frostming ? |
Signed-off-by: Frost Ming <[email protected]>
Done, but there is still a difference between MacOS and other platforms. See the test case. |
c1874b4 to
abf589c
Compare
…mote pdb tests Signed-off-by: Frost Ming <[email protected]>
abf589c to
9f51d1c
Compare
|
Thank you for the contribution! |
Before change:
After change:
Close gh-139940